From 551153f207012c627e108ba38b2fc0715a2f64fb Mon Sep 17 00:00:00 2001
From: Chris Morgan <me@chrismorgan.info>
Date: Sat, 8 Jan 2022 16:11:30 +1100
Subject: [PATCH] Ditch some silly trailing <br>s
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Half of these do nothing, and the other half I *want* to do nothing.
They’re all a crutch for better layout markup and styles.
---
 gitweb.cgi | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/gitweb.cgi b/gitweb.cgi
index 099d2b3..8ece13d 100755
--- a/gitweb.cgi
+++ b/gitweb.cgi
@@ -4679,11 +4679,6 @@ sub git_print_log {
 
 		print format_log_line_html($line) . "<br/>\n";
 	}
-
-	if ($opts{'-final_empty_line'}) {
-		# end with single empty line
-		print "<br/>\n" unless $skip_blank_line;
-	}
 }
 
 # return link target (what link points to)
@@ -5925,13 +5920,12 @@ sub git_log_body {
 		      $cgi->a({-href => href(action=>"commitdiff", hash=>$commit)}, "commitdiff") .
 		      " | " .
 		      $cgi->a({-href => href(action=>"tree", hash=>$commit, hash_base=>$commit)}, "tree") .
-		      "<br/>\n" .
 		      "</div>\n";
 		      git_print_authorship(\%co, -tag => 'span');
-		      print "<br/>\n</div>\n";
+		      print "</div>\n";
 
 		print "<div class=\"log_body\">\n";
-		git_print_log($co{'comment'}, -final_empty_line=> 1);
+		git_print_log($co{'comment'});
 		print "</div>\n";
 	}
 	if ($extra) {
@@ -8014,7 +8008,7 @@ sub git_commitdiff {
 		print "<div class=\"page_body\">\n";
 		if (@{$co{'comment'}} > 1) {
 			print "<div class=\"log\">\n";
-			git_print_log($co{'comment'}, -final_empty_line=> 1, -remove_title => 1);
+			git_print_log($co{'comment'}, -remove_title => 1);
 			print "</div>\n"; # class="log"
 		}
 
-- 
2.42.0