From: Chris Morgan <me@chrismorgan.info>
Date: Sat, 8 Jan 2022 05:34:46 +0000 (+1100)
Subject: Make JavaScript *actually* optional
X-Git-Url: https://git.chrismorgan.info/gitweb/commitdiff_plain/c36a795cb6b387c7bb8ddf103b71d937480c4d21

Make JavaScript *actually* optional

That is, don’t emit it if it isn’t going to be used.
---

diff --git a/gitweb.cgi b/gitweb.cgi
index 8ece13d..515d80c 100755
--- a/gitweb.cgi
+++ b/gitweb.cgi
@@ -4310,10 +4310,10 @@ sub git_footer_html {
 		insert_file($site_footer);
 	}
 
-	print qq!<script type="text/javascript" src="!.esc_url($javascript).qq!"></script>\n!;
 	if (defined $action &&
 	    $action eq 'blame_incremental') {
-		print qq!<script type="text/javascript">\n!.
+		print qq!<script src="!.esc_url($javascript).qq!"></script>\n!;
+		print qq!<script>\n!.
 		      qq!startBlame("!. esc_attr(href(action=>"blame_data", -replay=>1)) .qq!",\n!.
 		      qq!           "!. esc_attr(href()) .qq!");\n!.
 		      qq!</script>\n!;
@@ -4321,17 +4321,20 @@ sub git_footer_html {
 		my ($jstimezone, $tz_cookie, $datetime_class) =
 			gitweb_get_feature('javascript-timezone');
 
-		print qq!<script type="text/javascript">\n!.
-		      qq!window.onload = function () {\n!;
-		if (gitweb_check_feature('javascript-actions')) {
-			print qq!	fixLinks();\n!;
-		}
-		if ($jstimezone && $tz_cookie && $datetime_class) {
-			print qq!	var tz_cookie = { name: '$tz_cookie', expires: 14, path: '/' };\n!. # in days
-			      qq!	onloadTZSetup('$jstimezone', tz_cookie, '$datetime_class');\n!;
+		if (gitweb_check_feature('javascript-actions') || ($jstimezone && $tz_cookie && $datetime_class)) {
+			print qq!<script src="!.esc_url($javascript).qq!"></script>\n!;
+			print qq!<script>\n!.
+				qq!window.onload = function () {\n!;
+			if (gitweb_check_feature('javascript-actions')) {
+				print qq!	fixLinks();\n!;
+			}
+			if ($jstimezone && $tz_cookie && $datetime_class) {
+				print qq!	var tz_cookie = { name: '$tz_cookie', expires: 14, path: '/' };\n!. # in days
+					qq!	onloadTZSetup('$jstimezone', tz_cookie, '$datetime_class');\n!;
+			}
+			print qq!};\n!.
+				qq!</script>\n!;
 		}
-		print qq!};\n!.
-		      qq!</script>\n!;
 	}
 
 	print "</body>\n" .