From: Chris Morgan <me@chrismorgan.info>
Date: Fri, 7 Jan 2022 15:06:03 +0000 (+1100)
Subject: Add review for verhoeff v1.0.0
X-Git-Url: https://git.chrismorgan.info/crev-proofs/commitdiff_plain/7d768836b524bc5aab790a895329826c59c45c4e

Add review for verhoeff v1.0.0
---

diff --git a/QE5OVlHZ4QyOcMqdjXhS1MgsoZHvUqxOHNZwyfpsDIU/reviews/2022-01-package-jqCnIw.proof.crev b/QE5OVlHZ4QyOcMqdjXhS1MgsoZHvUqxOHNZwyfpsDIU/reviews/2022-01-package-jqCnIw.proof.crev
new file mode 100644
index 00000000..651a5e5
--- /dev/null
+++ b/QE5OVlHZ4QyOcMqdjXhS1MgsoZHvUqxOHNZwyfpsDIU/reviews/2022-01-package-jqCnIw.proof.crev
@@ -0,0 +1,30 @@
+----- BEGIN CREV PROOF -----
+kind: package review
+version: -1
+date: "2022-01-08T02:03:54.105679370+11:00"
+from:
+  id-type: crev
+  id: QE5OVlHZ4QyOcMqdjXhS1MgsoZHvUqxOHNZwyfpsDIU
+  url: "https://git.chrismorgan.info/crev-proofs"
+package:
+  source: "https://crates.io"
+  name: verhoeff
+  version: 1.0.0
+  revision: 67417456c81ccc241cb0e7257d6ca3a955e1d29e
+  digest: mM9owAVRQvXct8MS3WF2Fw8WZPgSv6lpM1WdjxWwwyQ
+review:
+  thoroughness: high
+  understanding: high
+  rating: strong
+comment: |-
+  I wrote this carefully. It’s well-documented, well-tested, and robust against
+  panicking except as documented (Verhoeff::calculate_verhoeff_check_digit or
+  verhoeff::calculate, on invalid input). Actually, I realised while writing
+  this review that VerhoeffMut::push_verhoeff_check_digit is also panicky
+  because it calculates a check digit, but I don’t think that warrants reducing
+  the rating from strong to positive, so here we are. (I’ve pushed an
+  appropriate change, but I don’t think it warrants even a 1.0.1 release.)
+----- SIGN CREV PROOF -----
+LJ2SYWIPHSNC49lmO1Bd4hGDAvT8lm-I4heOGrtdZPIRcDoOw2e9P4YxtKT_72r1Qwm3UfnpkCJqtM1UBkfkCw
+----- END CREV PROOF -----
+