651a5e5d804b7f5b126911946d97cb9b13db4a09
[crev-proofs] / QE5OVlHZ4QyOcMqdjXhS1MgsoZHvUqxOHNZwyfpsDIU / reviews / 2022-01-package-jqCnIw.proof.crev
1 ----- BEGIN CREV PROOF -----
2 kind: package review
3 version: -1
4 date: "2022-01-08T02:03:54.105679370+11:00"
5 from:
6 id-type: crev
7 id: QE5OVlHZ4QyOcMqdjXhS1MgsoZHvUqxOHNZwyfpsDIU
8 url: "https://git.chrismorgan.info/crev-proofs"
9 package:
10 source: "https://crates.io"
11 name: verhoeff
12 version: 1.0.0
13 revision: 67417456c81ccc241cb0e7257d6ca3a955e1d29e
14 digest: mM9owAVRQvXct8MS3WF2Fw8WZPgSv6lpM1WdjxWwwyQ
15 review:
16 thoroughness: high
17 understanding: high
18 rating: strong
19 comment: |-
20 I wrote this carefully. It’s well-documented, well-tested, and robust against
21 panicking except as documented (Verhoeff::calculate_verhoeff_check_digit or
22 verhoeff::calculate, on invalid input). Actually, I realised while writing
23 this review that VerhoeffMut::push_verhoeff_check_digit is also panicky
24 because it calculates a check digit, but I don’t think that warrants reducing
25 the rating from strong to positive, so here we are. (I’ve pushed an
26 appropriate change, but I don’t think it warrants even a 1.0.1 release.)
27 ----- SIGN CREV PROOF -----
28 LJ2SYWIPHSNC49lmO1Bd4hGDAvT8lm-I4heOGrtdZPIRcDoOw2e9P4YxtKT_72r1Qwm3UfnpkCJqtM1UBkfkCw
29 ----- END CREV PROOF -----
30