From: Chris Morgan <me@chrismorgan.info>
Date: Tue, 25 Jan 2022 13:12:16 +0000 (+1100)
Subject: Revert "removed unsafe code in favor of explicit assert"
X-Git-Tag: 1.0.0-beta.1~25
X-Git-Url: https://git.chrismorgan.info/anymap/commitdiff_plain/8abad057b08ea7f67d0f5aef40283b03146e2443

Revert "removed unsafe code in favor of explicit assert"

This reverts commit 479d756c992af132c6ba45248c65dc230c5986cf.

There’s nothing wrong with this patch, but I had never pulled this
commit to my local repository and had completely forgotten about it, and
today removed the unsafe code in a *different* direction that I like
better (`bytes.try_into().map(|bytes| u64::from_ne_bytes(bytes))`), so
reverting it so I can cleanly rebase is just easier for me!
---

diff --git a/src/raw.rs b/src/raw.rs
index dbd5e2c..07dccf8 100644
--- a/src/raw.rs
+++ b/src/raw.rs
@@ -10,6 +10,7 @@ use std::hash::{Hasher, BuildHasherDefault};
 #[cfg(test)]
 use std::mem;
 use std::ops::{Index, IndexMut};
+use std::ptr;
 
 use any::{Any, UncheckedAnyExt};
 
@@ -22,11 +23,10 @@ impl Hasher for TypeIdHasher {
     #[inline]
     fn write(&mut self, bytes: &[u8]) {
         // This expects to receive one and exactly one 64-bit value
-        assert!(bytes.len() == 8);
-        self.value = u64::from(bytes[0])       | u64::from(bytes[1]) << 8  |
-                     u64::from(bytes[2]) << 16 | u64::from(bytes[3]) << 24 |
-                     u64::from(bytes[4]) << 32 | u64::from(bytes[5]) << 40 |
-                     u64::from(bytes[6]) << 48 | u64::from(bytes[7]) << 56;
+        debug_assert!(bytes.len() == 8);
+        unsafe {
+            ptr::copy_nonoverlapping(&bytes[0] as *const u8 as *const u64, &mut self.value, 1)
+        }
     }
 
     #[inline]